Skip to content

[Chrore] Handle speedtest.net not reachable gracefully. #2313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexjustesen merged 2 commits into from
Aug 13, 2025
Merged

[Chrore] Handle speedtest.net not reachable gracefully. #2313

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b89439
Handle nicely
svenvg93 Aug 13, 2025
a6d8f50
Merge branch 'main' into chore/handle-speedtest-unreachable
svenvg93 Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion app/Actions/GetOoklaSpeedtestServers.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,15 @@ class GetOoklaSpeedtestServers
*/
public function handle(): array
{
return collect(self::fetch())->mapWithKeys(function (array $item) {
$servers = self::fetch();

// If the first item is not an array, treat as error or empty
if (empty($servers) || ! is_array($servers) || (isset($servers[0]) && ! is_array($servers[0]))) {
// Return error message as a single option so user can see the error
return ['error' => $servers[0] ?? 'Unable to retrieve servers'];
}

return collect($servers)->mapWithKeys(function (array $item) {
return [
$item['id'] => ($item['sponsor'] ?? 'Unknown').' ('.($item['name'] ?? 'Unknown').', '.$item['id'].')',
];
Expand Down