Enhance Telegram notifications with message thread support#2154
Closed
MrCaringi wants to merge 1 commit intoalexjustesen:mainfrom
Closed
Enhance Telegram notifications with message thread support#2154MrCaringi wants to merge 1 commit intoalexjustesen:mainfrom
MrCaringi wants to merge 1 commit intoalexjustesen:mainfrom
Conversation
Owner
|
Thanks for the PR, there are a couple of things missing on first glance that I'll leave in review notes. You'll also want to make sure you clone the repo locally and test the functionality and drop a screenshot of a successful test. |
alexjustesen
requested changes
Apr 17, 2025
Owner
alexjustesen
left a comment
There was a problem hiding this comment.
- Add thread ID as a settings migration (see previous settings migrations for examples)
- Add thread ID as a part of the Telegram form so the end-user can set the thread ID for the notification to use.
Author
|
thanks a lot for your support @alexjustesen ! I have to admit I am a little lost here, I am not familiar with pulls request, Please feel free to discard or modify it |
Owner
|
@MrCaringi thanks for the PR but I'm going to close it out. We're planning on implementing Apprise as a core notification channel to support additional services. Release tbd but at this point anything outside of "Database", "Email" and "Webhook" are considered deprecated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for message threads in Telegram notifications, allowing for more organized communication. This update modifies the notification handling to include an optional message thread ID.