Skip to content

Enhance Telegram notifications with message thread support#2154

Closed
MrCaringi wants to merge 1 commit intoalexjustesen:mainfrom
MrCaringi:main
Closed

Enhance Telegram notifications with message thread support#2154
MrCaringi wants to merge 1 commit intoalexjustesen:mainfrom
MrCaringi:main

Conversation

@MrCaringi
Copy link

Add support for message threads in Telegram notifications, allowing for more organized communication. This update modifies the notification handling to include an optional message thread ID.

@MrCaringi MrCaringi requested a review from alexjustesen as a code owner April 17, 2025 03:47
@alexjustesen alexjustesen added the feature New feature or request label Apr 17, 2025
@alexjustesen
Copy link
Owner

alexjustesen commented Apr 17, 2025

Thanks for the PR, there are a couple of things missing on first glance that I'll leave in review notes.

You'll also want to make sure you clone the repo locally and test the functionality and drop a screenshot of a successful test.

Copy link
Owner

@alexjustesen alexjustesen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Add thread ID as a settings migration (see previous settings migrations for examples)
  2. Add thread ID as a part of the Telegram form so the end-user can set the thread ID for the notification to use.

@MrCaringi
Copy link
Author

thanks a lot for your support @alexjustesen !

I have to admit I am a little lost here, I am not familiar with pulls request,
dont know if I have to do something else,

Please feel free to discard or modify it

@alexjustesen
Copy link
Owner

@MrCaringi thanks for the PR but I'm going to close it out. We're planning on implementing Apprise as a core notification channel to support additional services. Release tbd but at this point anything outside of "Database", "Email" and "Webhook" are considered deprecated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants