-
-
Notifications
You must be signed in to change notification settings - Fork 203
Add speedtest result bytes to results table #2150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add speedtest result bytes to results table #2150
Conversation
|
NOTES:
|
|
@ilteoood thanks for the PR! I'm going to leave a review on individual files with any changes but can you please remove any UI changes (i.e. the dashboard charts). Reason for this is I'm actively researching replacing the dashboard and don't want to add tech debt/scope at the moment. I also attached #2109 to #2146 and as I think through that feature I might come back to your PR with a couple changes. |
With UI changes you mean also the references to the result and export tables? |
Exports and results table we'll want, just the charts we dont. |
|
@alexjustesen everything should be in place with what you asked. |
alexjustesen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes! One more round of changes after finally having a moment to look at the PR.
|
One other quick note, you'll notice I changed the PR title and base branch. Going to roll this into the larger #2146 feature. |
9c723d6
into
alexjustesen:2146-feature-implement-a-data-cap
|
Hello. Just wanted to double check. Is this feature present in the latest release? I am not able to see the column for |
This got merged into a feature branch that hasn't been released yet. |
|
@alexjustesen are you still planning to complete that feature? |
It's still planned, I'm on parental leave at the moment so I'm not going to touch anything that's not a big fix for the next few weeks. |
Wow, that's a great achievement! Congratulations! π |

π Description
Closes #2109
π Documentation
I think it is not needed
πͺ΅ Changelog
β Added
π· Screenshots