Skip to content

Conversation

@ilteoood
Copy link

@ilteoood ilteoood commented Apr 16, 2025

πŸ“ƒ Description

Closes #2109

πŸ“– Documentation

I think it is not needed

πŸͺ΅ Changelog

βž• Added

  • storage and display of amount of bytes downloaded
  • storage and display of amount of bytes uploaded

πŸ“· Screenshots

image
image
image

@ilteoood ilteoood requested a review from alexjustesen as a code owner April 16, 2025 16:37
@ilteoood
Copy link
Author

ilteoood commented Apr 16, 2025

NOTES:

  • I'm not able to make the csv export to work. The column is generated but is always empty. I'm out of ideas, any help here is appreciated.
  • My PHP is rusty, sorry if this is a mess for you

@svenvg93
Copy link
Contributor

svenvg93 commented Apr 16, 2025

  • I'm not able to make the csv export to work. The column is generated but is always empty. I'm out of ideas, any help here is appreciated.

I checkend the export for you, it all works for me

SchermΒ­afbeelding 2025-04-16 om 21 26 30

Did you restart the queue:work in between changes? I had it in the past that a restart was needed for code changes to be picked up πŸ˜… .

@ilteoood
Copy link
Author

  • I'm not able to make the csv export to work. The column is generated but is always empty. I'm out of ideas, any help here is appreciated.

I checkend the export for you, it all works for me

SchermΒ­afbeelding 2025-04-16 om 21 26 30

Did you restart the queue:work in between changes? I had it in the past that a restart was needed for code changes to be picked up πŸ˜… .

Nope I haven't, this could explain what happened. Thank you so much!

@alexjustesen
Copy link
Owner

@ilteoood thanks for the PR!

I'm going to leave a review on individual files with any changes but can you please remove any UI changes (i.e. the dashboard charts). Reason for this is I'm actively researching replacing the dashboard and don't want to add tech debt/scope at the moment.

I also attached #2109 to #2146 and as I think through that feature I might come back to your PR with a couple changes.

@ilteoood
Copy link
Author

@ilteoood thanks for the PR!

I'm going to leave a review on individual files with any changes but can you please remove any UI changes (i.e. the dashboard charts). Reason for this is I'm actively researching replacing the dashboard and don't want to add tech debt/scope at the moment.

I also attached #2109 to #2146 and as I think through that feature I might come back to your PR with a couple changes.

With UI changes you mean also the references to the result and export tables?

@alexjustesen
Copy link
Owner

With UI changes you mean also the references to the result and export tables?

Exports and results table we'll want, just the charts we dont.

@ilteoood ilteoood requested a review from alexjustesen April 17, 2025 06:30
@ilteoood
Copy link
Author

@alexjustesen everything should be in place with what you asked.
Thank you so much for the time you dedicated reviewing this.

Copy link
Owner

@alexjustesen alexjustesen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! One more round of changes after finally having a moment to look at the PR.

@alexjustesen alexjustesen changed the base branch from main to 2146-feature-implement-a-data-cap April 19, 2025 13:52
@alexjustesen alexjustesen changed the title Feat/moved bytes Add speedtest result bytes to results table Apr 19, 2025
@alexjustesen alexjustesen added the feature New feature or request label Apr 19, 2025
@alexjustesen
Copy link
Owner

One other quick note, you'll notice I changed the PR title and base branch. Going to roll this into the larger #2146 feature.

@ilteoood ilteoood requested a review from alexjustesen April 19, 2025 15:06
@alexjustesen alexjustesen merged commit 9c723d6 into alexjustesen:2146-feature-implement-a-data-cap Apr 21, 2025
2 checks passed
@radh21301
Copy link

Hello. Just wanted to double check. Is this feature present in the latest release? I am not able to see the column for
Upload/Download Bytes.
FYI: I am using linuxserver image.

@alexjustesen
Copy link
Owner

alexjustesen commented May 20, 2025

Hello. Just wanted to double check. Is this feature present in the latest release? I am not able to see the column for
Upload/Download Bytes.
FYI: I am using linuxserver image.

This got merged into a feature branch that hasn't been released yet.

@ilteoood
Copy link
Author

@alexjustesen are you still planning to complete that feature?
It's been a while since my contribution has been merged and I would like to start using it.

@alexjustesen
Copy link
Owner

@alexjustesen are you still planning to complete that feature?
It's been a while since my contribution has been merged and I would like to start using it.

It's still planned, I'm on parental leave at the moment so I'm not going to touch anything that's not a big fix for the next few weeks.

@ilteoood
Copy link
Author

@alexjustesen are you still planning to complete that feature?
It's been a while since my contribution has been merged and I would like to start using it.

It's still planned, I'm on parental leave at the moment so I'm not going to touch anything that's not a big fix for the next few weeks.

Wow, that's a great achievement! Congratulations! πŸ‘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keep track of data usage

4 participants