Skip to content

Conversation

@svenvg93
Copy link
Contributor

@svenvg93 svenvg93 commented Apr 2, 2025

πŸ“ƒ Description

This PR adds and CheckInternetConnection action that checks if the Internet connections is active before starting the test.

Closes: #2111

πŸͺ΅ Changelog

βž• Added

  • Add CheckInternetConnection action to check for a http 200 code
  • Config option to specify the site to use.

✏️ Changed

  • Remove GetExternalIpAddress for the internet check

Docs pr: alexjustesen/speedtest-tracker-docs#71

@svenvg93 svenvg93 requested a review from alexjustesen as a code owner April 2, 2025 15:40
@alexjustesen alexjustesen added the bug Something isn't working label Apr 3, 2025
@alexjustesen alexjustesen merged commit 077957a into alexjustesen:main Apr 3, 2025
2 checks passed
@svenvg93 svenvg93 deleted the bug-internet-check branch April 3, 2025 12:50
@armond-avanes
Copy link

@svenvg93 Great job! Is it possible for you to add this new environment variable to the following list?
https://docs.speedtest-tracker.dev/getting-started/environment-variables

@svenvg93
Copy link
Contributor Author

@svenvg93 Great job! Is it possible for you to add this new environment variable to the following list? https://docs.speedtest-tracker.dev/getting-started/environment-variables

It is already added, it’s the SPEEDTEST_CHECKINTERNET_URL 😊

@armond-avanes
Copy link

@svenvg93 Great job! Is it possible for you to add this new environment variable to the following list? https://docs.speedtest-tracker.dev/getting-started/environment-variables

It is already added, it’s the SPEEDTEST_CHECKINTERNET_URL 😊

Thanks! Yes, you're right. It's already there. Not sure how I missed it! 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Speedtest fails due to blocked access to icanhazip.com by DoT – Allow override or skip external IP check.

3 participants