[Feature] Skip test when Public IP is in a list (#1714)#1795
Merged
alexjustesen merged 8 commits intomainfrom Nov 20, 2024
Merged
[Feature] Skip test when Public IP is in a list (#1714)#1795alexjustesen merged 8 commits intomainfrom
alexjustesen merged 8 commits intomainfrom
Conversation
* first commit * Commit it * lint * update-all-charts * push_local_git * add-timepicker * add-some-predefined-ranges * remove whiteline * Add_env_for_chart_start * change-env-and_time-ranges * change_average_to_orange * Revert "Add failed and thresholds" * first commit * change_api * update comments * Simplify * Seperate the IP check
alexjustesen
changed the title
alexjustesen
deleted the
1111-skip-test-when-public-ip-address-in-list
branch
|
Just want to clarify, to use this feature, we add the following Env var? Comma separated list of subnets/exact IPs? Example: |
Owner
Author
Correct, example in the docs: https://docs.speedtest-tracker.dev/getting-started/environment-variables#speedtest |
|
Can this be used in reverse to only run tests if a public IP is on a whitelist? |
Contributor
No, this can only be used to define public IPs not to run the test on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📃 Description
Expands on the work in #1714 that implements #1111. Massive thank you to @svenvg93 for getting this ball rolling 🤘.
closes #1111
🪵 Changelog
➕ Added
GetExternalIpAddressactionNetworkhelper✏️ Changed
"127.0.0.1" was found in public IP address skip list."127.0.0.1" was found in public IP address skip list within range "127.0.0.0/24".🔧 Fixed
https://icanhazip.com/instead ofhttps://ifconfig.co/to get the public IP address, it's backed by Cloudflare and less likely to be rate limited.