Fix ping url validation #1754
Merged
Fix ping url validation #1754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for catching that, completely missed my own comment. I'm going to make changes under your PR as a refactor to your proposed changes. |
Merged
Contributor
|
Technically we could use #1714 for the internet check as well. |
Owner
|
@nandi95 can you fix the lint errors and then happy to merge 🤘 |
Contributor
Author
|
@alexjustesen done |
alexjustesen
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📃 Description
Fixed the bug introduced in #1662 (comment)
This got released without the fix discussed so here's a quick patch. It is validated with tests