Improvements user resource#1732
Merged
alexjustesen merged 7 commits intoalexjustesen:refactor-user-resourcefrom Nov 8, 2024
Merged
Improvements user resource#1732alexjustesen merged 7 commits intoalexjustesen:refactor-user-resourcefrom
alexjustesen merged 7 commits intoalexjustesen:refactor-user-resourcefrom
Conversation
alexjustesen
requested changes
Oct 9, 2024
| ->email() | ||
| ->unique(ignoreRecord: true), | ||
| Forms\Components\TextInput::make('password') | ||
| Forms\Components\TextInput::make('password')->label('Password') |
Owner
There was a problem hiding this comment.
🤏 change, we can drop the label if the field name from make() is the same.
Contributor
Author
|
Yes, Got it! We can remove @alexjustesen |
alexjustesen
approved these changes
Nov 8, 2024
alexjustesen
added a commit
that referenced
this pull request
Nov 8, 2024
* Improvements user resource (#1732) * Improve textInput of password,password_confirmation * Improve textInput of password,password_confirmation * Drop the label if the field --------- Co-authored-by: Mohammad Salam <[email protected]> Co-authored-by: Alex Justesen <[email protected]> * refactored user resource * group user resource table actions --------- Co-authored-by: John Divam <[email protected]> Co-authored-by: Mohammad Salam <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📃 Description
A short description of the pull request changes should go here and the sections below should list in detail all changes. You can remove the sections you don't need.
🪵 Changelog
➕ Added
✏️ Changed
🔧 Fixed
🗑️ Removed
📷 Screenshots
If this PR has any UI/UX changes it's strongly suggested you add screenshots here.