[Bug] Remove writing server_id to an column for failed speedtests #1679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjustesen
added
feature
alexjustesen
changed the title
alexjustesen
requested changes
Sep 25, 2024
…93/speedtest-tracker into 1663-dont-write-server-id
Contributor
Author
|
@alexjustesen Just some screenshot for an working server id when there is no internet, non working server id, auto selection when there is no internet. Think that should cover all the senarios possible.
Auto selection when there is no internet Non working server id Working server id when there is no internet, |
svenvg93
changed the title
svenvg93
changed the title
alexjustesen
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📃 Description
Because the server_id was still written as separate column which does not exist anymore, it causes tests not to be marked as failed.
to close #1663
to close #1667
to close #1743
🪵 Changelog
🔧 Fixed
'server_id' => $this->serverId📷 Screenshots