Skip to content

Conversation

@svenvg93
Copy link
Contributor

@svenvg93 svenvg93 commented Aug 19, 2024

πŸ“ƒ Description

This PR adds the threshold reporting in the Resutls screen.

To close: #964
To close: #646

πŸͺ΅ Changelog

βž• Added

  • Calculate if the thresholds is breached at the end of the speedtests
    • If one of the thresholds is breached the status is set to Failed for the "overall threshold"
    • Set the status per threshold (Download, Upload, Ping) to failed when threshold is breached.
      • In order to re-use the status in the future.
  • Add database colunms to store results of the thresholds breach.
    - In order to re-use the status in the future.
    - In order to not having to check the status on every page loading.
    - Not update the status of other results when the thresholds value is changed.
  • Set status to "NotChecked" for when there is no thresholds defined.
  • Show Passed, Failed and NotChecked in the results table
  • Add the Overall thresholds status in the filters
  • Add "NotChecked" as default value to for old results
  • add to the the Results export
  • Change the filter to be modal layout.

πŸ“· Screenshots

image

image

@svenvg93 svenvg93 marked this pull request as ready for review August 20, 2024 12:09
@svenvg93 svenvg93 requested a review from alexjustesen as a code owner August 20, 2024 12:09
This was referenced Sep 3, 2024
@armond-avanes
Copy link

@svenvg93 Is there any ETA for when this PR is going to be updated/merged?

@svenvg93
Copy link
Contributor Author

svenvg93 commented Oct 29, 2024

@svenvg93 Is there any ETA for when this PR is going to be updated/merged?

Not really, waiting for review and testing to be finished.

@alexjustesen
Copy link
Owner

Merged #1813 which lays the groundwork for this feature, I still need to put into place a process for evaluating the benchmarks against the results and updating the result record accordingly. After that gets merged in we can add the benchmarks across the views.

@alexjustesen alexjustesen added the feature New feature or request label Nov 23, 2024
@svenvg93
Copy link
Contributor Author

Will be refactored in an different pr

@svenvg93 svenvg93 closed this Nov 23, 2024
@svenvg93 svenvg93 deleted the thresholds_results_db branch November 23, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Threshold reporting on Results screen. Color Coded Result Numbers

3 participants