Fix notifications layouts #1639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjustesen
approved these changes
Aug 5, 2024
alexjustesen
added a commit
that referenced
this pull request
Aug 8, 2024
* Add Placeholder text for notifications (#1570) first_commit * Add Gotify Notifications via Webhook (#1561) * first_commit * Ready! * Add_placeholder * change url --------- Co-authored-by: Alex Justesen <[email protected]> * Add Support for Slack Notifications via Webhook (#1522) * First Commit * Fix lint * add_url_placeholder * Fix the liniting * Add HealthCheck.io Notifications via Webhooks (#1567) * first_commit * linting * add_descrip_for_threshold * Change name * add_url_placeholder * fix_linting * Add Pushover Notifications via Webhooks (#1574) * add_pushover * add_placeholder * Linting --------- Co-authored-by: Alex Justesen <[email protected]> * Add ntfy Notifications via Webhooks (#1579) * first_push * Fix_json_payload * Add_auth_option * fix lint * fix packet_loss_% * added eof line --------- Co-authored-by: Alex Justesen <[email protected]> * Add Ookla URL to the notification (#1615) * first commit * added eof line --------- Co-authored-by: Alex Justesen <[email protected]> * Fix notifications layouts (#1639) first commit --------- Co-authored-by: Sven van Ginkel <[email protected]>
alexjustesen
added a commit
that referenced
this pull request
Aug 8, 2024
* Develop v0.21.0 (additional notification channels) (#1647) * Add Placeholder text for notifications (#1570) first_commit * Add Gotify Notifications via Webhook (#1561) * first_commit * Ready! * Add_placeholder * change url --------- Co-authored-by: Alex Justesen <[email protected]> * Add Support for Slack Notifications via Webhook (#1522) * First Commit * Fix lint * add_url_placeholder * Fix the liniting * Add HealthCheck.io Notifications via Webhooks (#1567) * first_commit * linting * add_descrip_for_threshold * Change name * add_url_placeholder * fix_linting * Add Pushover Notifications via Webhooks (#1574) * add_pushover * add_placeholder * Linting --------- Co-authored-by: Alex Justesen <[email protected]> * Add ntfy Notifications via Webhooks (#1579) * first_push * Fix_json_payload * Add_auth_option * fix lint * fix packet_loss_% * added eof line --------- Co-authored-by: Alex Justesen <[email protected]> * Add Ookla URL to the notification (#1615) * first commit * added eof line --------- Co-authored-by: Alex Justesen <[email protected]> * Fix notifications layouts (#1639) first commit --------- Co-authored-by: Sven van Ginkel <[email protected]> * updated npm dependencies --------- Co-authored-by: Sven van Ginkel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing some double check testing I noticed that for some the layout for the bold texts was not correct. This PR fixes them :)