Skip to content

Result created event #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexjustesen merged 15 commits into from
Nov 10, 2022
Merged

Result created event #138

alexjustesen merged 15 commits into from
Nov 10, 2022

Conversation

@alexjustesen
Copy link
Owner

@alexjustesen alexjustesen commented Nov 10, 2022 •
edited
Loading

Changelog

This PR removes reliance on model observers and instead implements events and listeners. This change is being done so actions after a speedtest can easily scale and isolates any failing tasks.

Added

  • ResultCreated event on the Result model
  • each absolute threshold metric triggers it's own notification
  • moved influxdb job to listener

Changed

  • made influxdb inputs required when enabled

Fixed

Preview

image
Absolute threshold notifications

@alexjustesen alexjustesen added the feature New feature or request label Nov 10, 2022
@alexjustesen alexjustesen self-assigned this Nov 10, 2022
@alexjustesen alexjustesen mentioned this pull request Nov 10, 2022
Closed
@alexjustesen alexjustesen changed the title [wip] Result created event Result created event Nov 10, 2022
@alexjustesen alexjustesen marked this pull request as ready for review November 10, 2022 19:41
@alexjustesen alexjustesen merged commit 67132b3 into main Nov 10, 2022
@alexjustesen alexjustesen deleted the result-created-event branch November 10, 2022 19:41
@Kunalb963 Kunalb963 mentioned this pull request Oct 7, 2023
Closed
@zackmuc zackmuc mentioned this pull request Feb 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexjustesen alexjustesen

Labels

feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Thresholds wrongly triggering a notification

2 participants

@alexjustesen