Skip to content

Conversation

@svenvg93
Copy link
Contributor

@svenvg93 svenvg93 commented Apr 4, 2024

📃 Description

This PR introduces support for the upload and download Latency returns in the speedtest json file. I took the liberty to creating this as I think that this information is useful for troubleshooting and monitoring.
The layout might need some tuning to your liking.

Disclaimer: im not a developer so it might not be the best code ever seen ;)

🪵 Changelog

➕ Added

  • Add a graph for the Upload Latency (High, Low, Avg)
  • Add a graph for the Download Latency (High, Low, Avg)
  • Add the Up/Download latency to the results page, csv export, and influxdb

📷 Screenshots

Scherm­afbeelding 2024-04-04 om 18 40 54

@svenvg93 svenvg93 requested a review from alexjustesen as a code owner April 4, 2024 16:47
@alexjustesen
Copy link
Owner

alexjustesen commented Apr 5, 2024

Thanks for the PR @svenvg93, the lint workflow is going to throw some suggested changes. Update the PR based on those failures and I'll test locally.

You can run the linter locally with sail bin duster lint --using=pint -v.

@svenvg93
Copy link
Contributor Author

svenvg93 commented Apr 5, 2024

Thanks for the PR @svenvg93, the lint workflow is going to throw some suggested changes. Update the PR based on those failures and I'll test locally.

Thanks! I will try to figure it out and update the PR

@svenvg93
Copy link
Contributor Author

svenvg93 commented Apr 5, 2024

@alexjustesen Should be all good now. It passed the local test as suggested :)

@alexjustesen alexjustesen added the feature New feature or request label Apr 5, 2024
@alexjustesen alexjustesen merged commit bfe9117 into alexjustesen:main Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants