Skip to content

[Chore] Deprecate general settings site name #1332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexjustesen merged 4 commits into from
Mar 31, 2024
Merged

[Chore] Deprecate general settings site name #1332

alexjustesen merged 4 commits into from
Mar 31, 2024

Conversation

@alexjustesen
Copy link
Owner

@alexjustesen alexjustesen commented Mar 31, 2024

📃 Description

This PR deprecates general settings site_name variable as part of the work detailed in #1258.

✅ To-dos

🪵 Changelog

✏️ Changed

  • use config('app.name') in notifications

🗑️ Removed

  • deprecated site_name from general settings

@alexjustesen alexjustesen added the chore Nothing fancy, just needs to get done label Mar 31, 2024
@alexjustesen alexjustesen self-assigned this Mar 31, 2024
@alexjustesen alexjustesen changed the title Deprecate general settings site name [Chore] Deprecate general settings site name Mar 31, 2024
@alexjustesen alexjustesen merged commit 4f84a6a into main Mar 31, 2024
@alexjustesen alexjustesen deleted the deprecate-general-settings-site-name branch March 31, 2024 00:08
@alexjustesen alexjustesen mentioned this pull request Mar 31, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexjustesen alexjustesen

Labels

chore Nothing fancy, just needs to get done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexjustesen