[Chore] Refactored executing Ookla speedtests and added new events#1264
Merged
alexjustesen merged 5 commits intomainfrom Feb 29, 2024
Merged
[Chore] Refactored executing Ookla speedtests and added new events#1264alexjustesen merged 5 commits intomainfrom
alexjustesen merged 5 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📃 Description
This PR refactored running manual and scheduled Ookla speedtests. This work was needed to bring flexibility to the process for future speedtest services and additional methods for triggering speedtests.
This PR also makes use of new
Resultmodel statuses where as result isStartedand thenCompletedorFailed.🪵 Changelog
➕ Added
SpeedtestCompleted,SpeedtestFailedandSpeedtestStartedfor listeners to hook into.✏️ Changed
🗑️ Removed
app:run-ookla-speedtestcommand, no longer needed.ResultCreatedevent.🪜 Process
Manual process
flowchart TD A[Manual trigger \n i.e. button click] --> B(Run speedtest \n action) B --> C(Queue execute \n speedtest job) C --> D(Worker process \n speedtest job)Scheduled process
flowchart TD A[Task Scheduler] --> B{Schedule \n exists?} B --> |No| Z(End process) B --> |Yes| C(Run scheduled \n speedtests action) C --> D{Is Ookla \n speedtest due?} D --> |No| Z D --> |Yes| E(Run speedtest \n action) E --> F(Queue execute \n speedtest job) F --> G(Worker process \n speedtest job)