Skip to content

[Bug] Fixed incorrect file size bits calculation#1182

Merged
alexjustesen merged 3 commits intomainfrom
fixed-incorrect-file-size-bits-calculation
Feb 20, 2024
Merged

[Bug] Fixed incorrect file size bits calculation#1182
alexjustesen merged 3 commits intomainfrom
fixed-incorrect-file-size-bits-calculation

Conversation

@alexjustesen
Copy link
Owner

📃 Description

This PR fixes a calc error on the dashboard and table views. This does not address the API where values are being passed to Homepage or Heimdall yet.

🪵 Changelog

✏️ Changed

  • use Number helper on results table

🔧 Fixed

  • when converting bits use the power of 1000 not 1024 (for bytes)

@alexjustesen alexjustesen merged commit 6b73a45 into main Feb 20, 2024
@alexjustesen alexjustesen deleted the fixed-incorrect-file-size-bits-calculation branch February 20, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong Download and Upload Value Speed shown in Gbps (Dashboard), Mbps (Result list) and even in Pbps (API - Homepage)

1 participant