-
-
Notifications
You must be signed in to change notification settings - Fork 203
Closed
Labels
needs reviewA maintainer needs to look at this issue stillA maintainer needs to look at this issue stillquestionFurther information is requestedFurther information is requested
Description
Pre-work
- I have read the docs.
- I have searched open and closed issues.
- I agree to follow this project's Code of Conduct.
Description
The test notification for apprise expects the settings for the Apprise Server URL already to be saved, even though we show the button when the channel_url are filled in and not saved yet
speedtest-tracker/app/Actions/Notifications/SendAppriseTestNotification.php
Lines 27 to 39 in fd7a034
| $settings = app(NotificationSettings::class); | |
| $appriseUrl = rtrim($settings->apprise_server_url ?? '', '/'); | |
| if (empty($appriseUrl)) { | |
| Notification::make() | |
| ->title('Apprise Server URL is not configured') | |
| ->body('Please configure the Apprise Server URL in the settings above.') | |
| ->danger() | |
| ->send(); | |
| return; | |
| } | |
Expected Behavior
Don’t show the button without saving or don’t require the apprise server url to be saved.
Steps to Reproduce
Setup apprise without saving
Deployment Environment
Docker Compose
Application Information
N/AWhat browser(s) are you seeing the problem on?
All
Logs
ReadB and Gumpy-Q
Metadata
Metadata
Assignees
Labels
needs reviewA maintainer needs to look at this issue stillA maintainer needs to look at this issue stillquestionFurther information is requestedFurther information is requested