Skip to content

[Bug] Apprise test notification throws error when not saved #2618

@svenvg93

Description

@svenvg93

Pre-work

  • I have read the docs.
  • I have searched open and closed issues.
  • I agree to follow this project's Code of Conduct.

Description

The test notification for apprise expects the settings for the Apprise Server URL already to be saved, even though we show the button when the channel_url are filled in and not saved yet

$settings = app(NotificationSettings::class);
$appriseUrl = rtrim($settings->apprise_server_url ?? '', '/');
if (empty($appriseUrl)) {
Notification::make()
->title('Apprise Server URL is not configured')
->body('Please configure the Apprise Server URL in the settings above.')
->danger()
->send();
return;
}

Expected Behavior

Don’t show the button without saving or don’t require the apprise server url to be saved.

Steps to Reproduce

Setup apprise without saving

Deployment Environment

Docker Compose

Application Information

N/A

What browser(s) are you seeing the problem on?

All

Logs

Metadata

Metadata

Assignees

No one assigned

    Labels

    needs reviewA maintainer needs to look at this issue stillquestionFurther information is requested

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions