-
Notifications
You must be signed in to change notification settings - Fork 34
Description
On the env vars, pls make another row for defaults (and fill it). Sometime you list the defaults together with the description, sometimes not.
I'm a person I use defaults when they are ok for me. As an example:
Take SPEEDTEST_INTERNET_CHECK_HOSTNAME I thought when this is unset by me, there is no internet check. That is wrong, as you can see here:
When a speedtest is being processed Speedtest Tracker will make a ICMP ping to icanhazip.com to check if there is an internet connection before starting the Speedtest.
Same for SPEEDTEST_EXTERNAL_IP_URL.
Also the env var SPEEDTEST_SKIP_IPS says public IP addresses in the description and you listed private as an example. Smart people know that, so I think you should adjust the example or the description.