Skip to content

Conversation

@lukazso
Copy link
Contributor

@lukazso lukazso commented Jul 29, 2022

Hi, first of all thanks for open sourcing your implementations!

  1. I noticed that when installing the project as pip install git+https://github.com/adipandas/multi-object-tracker.git you cannot use the package in your python project since setup.py misses find_packages(). I added that, so now you can install the project directly as a dependency into your other python projects.
  2. When I imported the tracker I received an error that the module ipyfilechooser was not installed, so I added it to the requirements.txt.

@adipandas adipandas merged commit bfbc2b1 into adipandas:master Jul 30, 2022
@adipandas
Copy link
Owner

Hello @lukazso, thanks for this pull request. I have reviewed/merged it!

@adipandas adipandas self-requested a review July 30, 2022 23:40
@adipandas adipandas added the enhancement New feature or request label Jul 30, 2022
Copy link
Owner

@adipandas adipandas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!! Thank you for the contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants