Creational Pattern: Builder pattern applied #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builder pattern has been applied to app/location/init.py
Why?
There are two kinds of location, Location and Timelined location. We can see Timeline location as a subclass of Location. One subclass is fine, but if we need more kinds of location in the future for example: location which only has case numbers, location which only has basic info or location which only has geo info, we'll have to create more sub classes which will makes the code long and complicated. So we can apply builder pattern to simplify the code.
How?
Add Builder class to initialize builder method.
Add class CaseNumber, Locationinfo, timeline and BaseLocation as 'parts'
Transfer class Location and TimelinedLocation to 'product'
Add class BuildLocation(Builder) and BuildTimeLinedLocation(Builder) to build location object and timelinedlocation object.