Fix translation all words #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rouilj
reviewed
May 18, 2024
| th.textContent = header; | ||
| footerRow.appendChild(th); | ||
| }); | ||
| const footerRow = headerRow.cloneNode(true); |
Contributor
|
Except for the doc issue looks good to me. |
Contributor
Author
|
@rouilj um doc issues. you mean should I not have included that section or just refer them to roundup docs for translation? |
Contributor
|
Including the section is fine Especially since the translation strings can't be automatically extracted by roundup-gettext. I think your example is wrong. I don't think: is going to work. When you set up: msgid "next" |
Contributor
Author
|
@rouilj Fixed the docs and added warning for case sensitive msgid Merging it into main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.