Skip to content

Cancel button in popup is generating valueSelected event #85

@rouilj

Description

@rouilj

as a result the value is being overwritten in the main window.

See:

tracker/html/classhelper.js

Lines 742 to 750 in dad66fe

const cancel = document.createElement("button");
cancel.textContent = ClassHelper.translations["cancel"];
cancel.addEventListener("click", () => {
this.dispatchEvent(new CustomEvent("valueSelected", {
detail: {
value: preview.value
}
}));
});

I think the right thing to do here @malav is this.popupRef.close() right? Is there any reason to
generate a custom close event?

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions