GitHub Tracker by Joanna Lodell - Week 7#97
GitHub Tracker by Joanna Lodell - Week 7#97joannalodell19 wants to merge 11 commits intoTechnigo:mainfrom
Conversation
JensBergqvist
left a comment
JensBergqvist
left a comment
There was a problem hiding this comment.
Hi Joanna! You made a beautiful and well working site! You should be really proud of yourself!
I only saw some minor things, like console.logs still there in the JS on row 44, 47, 50 and 53. Like i wrote in the comment I forget to remove these aswell all the time. But I think we're gonna get asked by Technigo to go back and remove them for any new projects now.
Keep up the awesome work!
| fetch(API_PROFILE) | ||
| .then(res => res.json()) | ||
| .then(data => { | ||
| // console.log(data) |
There was a problem hiding this comment.
To make the code more clean, try and remember to remove console.logs before sending it. I miss these all the time aswell so I'm not critizicing in any way. I belive they will be much harder on us removing these further on.
|
|
||
| getRepos() | ||
|
|
||
| // Pull requests for each project |
There was a problem hiding this comment.
Good comment! Makes it easy to understand what the code does, even for someone who is new to coding and maybe dosen't understand exactly what the function does!
| // If pull request done by user, getCommits function is invoked | ||
| if (myPullRequest) { | ||
| getCommits(myPullRequest.commits_url, repo.name); | ||
| } else { | ||
| document.getElementById(`commit-${repo.name}`).innerHTML = | ||
| "No pull request done by user"; |
There was a problem hiding this comment.
Very nice code! I struggled alot to make my if statements actually work, and my code became way longer to get the same result!
2 participants
https://modest-archimedes-0644fa.netlify.app/