Conversation
| ## View it live | ||
|
|
||
| Every project should be deployed somewhere. Be sure to include the link to the deployed project so that the viewer can click around and see what it's all about. | ||
| https://silly-mestorf-a038ed.netlify.app/ |
There was a problem hiding this comment.
If you would like to change the name of the site you can do this on Netlify if you go to the site overview > site settings > and under site information > change site name
| .then(res => res.json()) | ||
| .then((data) => { | ||
| profileInfo.innerHTML += ` | ||
| <h2><img src = "./github.png"><a href="https://github.com/${userName}" target="_blank">${data.login}</a></h2> |
There was a problem hiding this comment.
I love the small GitHub img next to your name! And it looks great in desktop mode that you placed this section and the chart to the left of the projects!
| .then(res => res.json()) | ||
| .then(data => { | ||
| //-----Filter repos-----// | ||
| const forkedRepos = data.filter((repo) => repo.fork && repo.name.startsWith('project-')); |
There was a problem hiding this comment.
Very nice that you have both the fork and the project filters in the same row!
| `<div id= "projects"> | ||
| <h3><a href = ${repo.html_url}> ${repo.name} </a></h3> | ||
| <p>Default branch: ${repo.default_branch}</p> | ||
| <p>Latest push: ${repo.pushed_at.slice(0, 10)}, ${repo.pushed_at.slice(11, 16)}</p> |
There was a problem hiding this comment.
what a nice detail with the time to here!
| //-----Check if i have a pullrequest for that repo user login and repo owner-----// | ||
| const myPullRequest = data.find( | ||
| (pull) => pull.user.login === repo.owner.login); | ||
| //-----If yes, start function getCommits-----// |
There was a problem hiding this comment.
Here you could also add a link to the pullrequests - I did it like this:
if (myPullRequests) {
document.getElementById(${repo.name}).innerHTML +=
Pull request
} else {
document.getElementById(${repo.name}).innerHTML +=
Pull request made by teammate
}| margin-top: 0; | ||
| } | ||
|
|
||
| .big-container a:hover { |
There was a problem hiding this comment.
I loved this hover effect - it looks amazing!
And also the other styling of the page is supernice - you did a great job with it : D!
No description provided.