GitHub tracker Joanna Ringqvist#94
Conversation
…unction. Also added more comments
EmmaaBerg
left a comment
EmmaaBerg
left a comment
There was a problem hiding this comment.
A really good job! A well-structured page and code that was easy to understand. It follows the guidelines for how to write good code as well. It fulfills the blue requirements and works fine in the responsive aspect. I liked the way you presented your projects in a table and how it is responsive in itself on smaller screens.
|
|
||
| <!-- This will be used to draw the chart 👇 --> | ||
| <canvas id="chart"></canvas> | ||
| <header> |
There was a problem hiding this comment.
Overall a clean and structured HTML and good with the semantic HTML-elements
| <h1 class="heading">GitHub Tracker for:</h1> | ||
| <div class="user"> | ||
| <p class="username" id="username"></p> | ||
| <img id="picture" class="picture" /> |
There was a problem hiding this comment.
For images I think the alt -attribute is good to add if the image can't be displayed. But I'm not sure if it should be included here or in the JS where the fetch is?
|
|
||
| <script src="./script.js"></script> | ||
| <main> | ||
| <table class="projects"> |
There was a problem hiding this comment.
Really liked the way you presented the data in a table!
| </main> | ||
| <canvas id="chart" class="chart"> | ||
| </canvas> | ||
| <p id="numberOfProjects" class="number-of-projects"></p> |
There was a problem hiding this comment.
Good naming conventions for JS and CSS
| <td id="commits-${repo.name}"></td> | ||
| <td><a class="repo-url" href="${repo.html_url}">${repo.html_url}</a></td> |
There was a problem hiding this comment.
A really small comment, but here is the only time double quotation marks are used. To make the code consistent only single quotation marks (or double) should be used.
2 participants
No description provided.