project-github-tracker_åsa-sieurin#89
Conversation
sofiaringstedt
left a comment
sofiaringstedt
left a comment
There was a problem hiding this comment.
Overall a very nice and well functioning website that meets the requirements of this weeks project, good job!
I like your design and your animations, as always! :)
You structured your JS fetches in a nice and easy way, so they work well and are also easy to read. One thing I noticed is that I would have really enjoyed even more comments in your code, especially in your CSS where you have so much nice, extra styling, it would have made it easier for me to follow and learn from your code :)
Overall a well-funcitoning and nice looking website that does what it should and beyond, with well-structured code behind it
| <img src="${json.avatar_url}" alt= "avatar"> | ||
| <p class="user-name">${json.login}</p> | ||
| </div> | ||
| <div class="circles"> |
There was a problem hiding this comment.
wow, didn't realize that you had added the animations via the JS script, nice touch
|
|
||
| filterProjects.forEach((project) => { | ||
| // print out the project name, branch, latest push, url | ||
| projects.innerHTML += ` |
There was a problem hiding this comment.
perhaps the indentations and line breaks just looks a bit off here on GitHub and not in your actual code, seems like it could be a good idea too brush it up a bit for readability
| singleProject.innerHTML += `<p class="pull-requests">Pull requests: ${filteredPR.length}</p>`; | ||
|
|
||
| // fetch all commits and print them out | ||
| const API_COMMITS = `https://api.github.com/repos/sieurin/${reponame}/commits`; |
There was a problem hiding this comment.
smart how you divided up the fetches here, allowing you to get to the number of commits even tho you were not the one who made the initial pull request!
| } | ||
|
|
||
| .projects:hover { | ||
| background-color: var(--my-black); |
There was a problem hiding this comment.
really like this styling, totally new for me!
2 participants
So much struggle with this personal token thing and get this site published on Netlify. I'm glad I started on time but unfortunately I ended up not having so much time for styling, and adding some other functionality, as I had planned for. But I am happy with the result given the conditions. Tough week, good enough :)