Project Github Tracker - Michael#87
Conversation
code/script.js
Outdated
| } | ||
| // Formatting MONTHS | ||
| const months = ["Jan", "Feb", "Mar", "Apr", "May", "Jun", "Jul", "Aug", "Sep", "Oct", "Nov", "Dec"] | ||
| let lastCommitMonthNumber = lastCommitDateRaw.substring(5,7).replace("0","") |
There was a problem hiding this comment.
Oops - already found a mistake here. When we hit October I'm gonna run into problems 😉
There was a problem hiding this comment.
Good thing you found it because it would most definitely have escaped my notice!
amandatange
left a comment
amandatange
left a comment
There was a problem hiding this comment.
You have done a superb github tracker and gone above and beyond the requirements! There is a lot going on in your code but it's filled with comments that explain what is going on, though much of it is beyond my level! However, it takes no brains to see that the resulting website is brilliant, it works really well and looks very very nice.
| @@ -0,0 +1,235 @@ | |||
| //DOM-selector for sprint chart | |||
There was a problem hiding this comment.
The HOURS that must have gone into this is just astounding, such patience and brains!! The result also looks so good, even though as you had noticed, once October comes it'll need some small changes, but by then you'll be an actual developer god!
| } if (exist === false) { | ||
| document.getElementById(`${projectsID}2`).innerHTML += ` | ||
| <p>Pull request unavailable.</p> |
There was a problem hiding this comment.
Nice solution to be able to display that there isn't a PR! Good for the user to see and not have to wonder where the PR link is:)
| }; | ||
|
|
||
| // Function for opening and closing the projects items | ||
| const openSesame = (projectID) => { |
There was a problem hiding this comment.
This was a very smart thing to add, partly because it's an objectively difficult thing to deal with haha, and I know you had some bugs with the reapplication of the accordion, but you've solved it perfectly! And partly because the data can take a little with to fetch but it doesn't show on yours since they're hidden before you click it! So smart!
| @@ -1,3 +1,246 @@ | |||
| /* Remove Pre-set Styling */ | |||
There was a problem hiding this comment.
The styling is as always impeccable and I have no comments on anything, I will only say that I am going to be back here again and again to reference your handiwork.
2 participants
No description provided.