GitHub Tracker - Arianna#86
Conversation
sieurin
left a comment
sieurin
left a comment
There was a problem hiding this comment.
Hi Ari,
Such a well done job on your git hub tracker! Your site works as intended in all screen sizes and different browsers. There are no bugs. Your project has fulfilled all the blue and general requirements and you seem to have met the red level requirements as well. You should be so proud of yourself!
Your code is well organized but the most impressive thing with your code is that it’s so condensed and clean. It’s really a joy to read it.
I have just made some small comments, merely suggestions. So, I will keep this code review as short as your code :)
| const fetcher = (url, token, callback) => { | ||
| fetch(url, token) | ||
| .then((response) => { | ||
| return response.json(); | ||
| }) | ||
| .then((data) => { | ||
| callback(data); | ||
| }) | ||
| .catch((error) => { | ||
| console.log(error); | ||
| }) | ||
| }; | ||
|
|
There was a problem hiding this comment.
Love this! Makes the code so much cleaner below. Will ask you more questions about this :)
| background-color: rgb(63, 203, 226, 0.15); | ||
| padding: 1rem 1rem; | ||
| margin: 1rem; | ||
| line-height: 22px; |
There was a problem hiding this comment.
Is there any reason why you use pixels sometimes and rem sometimes?
| padding: 1rem 0rem; | ||
| } | ||
|
|
||
| .profile-wrapper { |
There was a problem hiding this comment.
Very clear and descriptive css naming conventions in general!
| }; | ||
|
|
||
| fetcher (url.user, OPTIONS, ((userProfile) => { | ||
| document.getElementById('profile').innerHTML += ` |
There was a problem hiding this comment.
Maybe you can add some comments to your code. It's very easy to follow, because of your clean code, but I think comments is a good thing to make it even more easy to follow along with your code.
2 participants
Here's a link to my project live: https://githubtracker-ari.netlify.app/