Savannah Hayes - GitHub Tracker#85
Conversation
|
|
||
| const username = "savannah-hayes"; | ||
| const USER_URL = `https://api.github.com/users/${username}`; | ||
| const API_TOKEN = TOKEN || process.env.API_KEY |
| displayHtml() | ||
|
|
||
| const displayProfileData = (profileData) => { | ||
| const { avatar_url, name, login, bio, followers, following, location } = profileData; |
There was a problem hiding this comment.
Nice with destructuring! I guess it's to make these data available outside of this function as well as "props"?
There was a problem hiding this comment.
Oh I get it now! These are values from the data retrieved in the fetch, so you reused them to simply display in the html. This was so clever.
| <header id="header" class="header"></header> | ||
| <main class="body-wrapper"> | ||
| <aside class="aside" id="aside"></aside> | ||
| <section class="projects" id="projects"> |
jjwwkkmm
left a comment
jjwwkkmm
left a comment
There was a problem hiding this comment.
I am impressed by the code and the styling of the page. Nice idea of making several linked pages and particularly impressed by the part where you destructured the returned data object from the fetch and made use of the values in the html form for display.
The progress bars styling was also a nice extra feature improving the UX.
The only question I might have is that the pull request a link is linked to #, which I guess you put there to make it a home-page kind of link, but when I first tried the website without looking at the code I was wondering why the link didn't work.
Great job and code!
2 participants
https://gallant-ardinghelli-8ae929.netlify.app/