project-github-tracker Frida Axelsson#83
Conversation
savannah-hayes
left a comment
savannah-hayes
left a comment
There was a problem hiding this comment.
Great job with your project, I am able to understand your code easily. Everything works as it should and nothing is broken. It seems to meet the blue level requirements from what I can see and it looks nice.
Just a small tip I would add is that your code could be tided up a little, with cleaning up the empty lines and removing console logs, and so on.. But overall great job on this weeks project you should be proud of the project you have built!
| const drawChart = (amount) => { | ||
| const labels = [ | ||
| 'Projects done', | ||
| 'Technigo projects', | ||
| ]; | ||
|
|
||
| const data = { | ||
| labels: labels, | ||
| datasets: [{ | ||
| label: 'My First dataset', | ||
| data: [amount, 19-amount], |
There was a problem hiding this comment.
Great job passing in the amount of projected you have completed in your drawChart function. Nicely done!
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
I would suggest removing the empty lines you have here and the ones in your css file to keep your file clean.
| @@ -0,0 +1 @@ | |||
| code/secret.js No newline at end of file | |||
There was a problem hiding this comment.
Did you know you could add the .DS_Store file into your gitignore file as well so it doesn't get committed?
| ); | ||
| } | ||
|
|
||
| console.log('test') No newline at end of file |
There was a problem hiding this comment.
I think you forgot to remove a console log here on line 37 :)
| <header class="hero"> | ||
| <div id="userDataWrapper" class="user-data-wrapper"></div> | ||
| <section class="img-wrapper" id="imgWrapper"> </section> | ||
| </header> | ||
|
|
||
| <main class="project-wrapper" id="projects"></main> | ||
|
|
||
| <!-- This will be used to draw the chart 👇 --> | ||
| <canvas id="chart"></canvas> | ||
| <section class="chart-box"> | ||
| <divc class="chart-wrapper" style="position: relative;"> | ||
| <canvas id="chart"></canvas> | ||
| </div> | ||
| </section> | ||
|
|
||
| <footer> | ||
| <p> images from unsplash.com</p> | ||
| </footer> |
There was a problem hiding this comment.
NIce job keeping your html file minimal and great job using semantic html.
|
|
||
| <script src="./script.js"></script> | ||
| <script src="./chart.js"></script> | ||
| <script src="./secret.js"></script> |
There was a problem hiding this comment.
I would suggest removing this script tag for the secret js file. I don't believe you have a secret js file?
| const options = { | ||
| method: 'GET', | ||
| headers: { | ||
| Authorization: 'API_TOKEN' | ||
| } | ||
| } |
There was a problem hiding this comment.
I would suggest removing this as well since, I mentioned earlier that you don't seem to have a secret file and I think you can remove this code from line 11-16, since you don't seem to be using it in your script file.
| console.log(data) | ||
| console.log(data[0].owner) |
There was a problem hiding this comment.
I think you forgot to remove some console logs here in this file as well :)
| const forkedRepos = data.filter((repo) => repo.fork && repo.name.startsWith("project-")) | ||
| console.log(forkedRepos) | ||
|
|
||
| getPullRequests(forkedRepos) |
There was a problem hiding this comment.
Nice job passing on your forked projects into your getPullRequests function.
| background-image: url(./img/susan-wilkinson-SjhL-Zrol6A-unsplash.jpg) ; | ||
| background-position: left bottom; | ||
| background-repeat: no-repeat; | ||
| background-size: cover; | ||
| background-attachment: fixed; | ||
| position: relative; | ||
| height: 300px; | ||
| width: 100%; | ||
| display: flex; | ||
| justify-content: center; | ||
| align-items: center; | ||
| } |
There was a problem hiding this comment.
Great job utilizing flex box in your project!
|
Frida, as written above. your code is easy to follow and to understand the functions. |
3 participants
No description provided.