Open
Conversation
Kyparn
reviewed
Mar 2, 2022
| <!-- <script src="script.js" type="module" defer></script> --> | ||
| </head> | ||
| <body> | ||
| <div id="root"></div> |
| }, | ||
| }); | ||
| } | ||
|
|
There was a problem hiding this comment.
The chart looks nice, tok some time to understand it all, maybe right some comments on how it works also :)
Comment on lines
+2
to
+18
| /* colors */ | ||
| --color-black: #0e1116; | ||
| --color-light-black: #171b21; | ||
| --color-superlight-black: #20242b; | ||
| --color-deep-grey: #21262c; | ||
| --color-grey: #353941; | ||
| --color-light-grey: #2a2f35; | ||
| --color-deep-white: #44474c; | ||
| --color-white: #f1f7fa; | ||
| --color-light-white: #8d949c; | ||
| --color-primary: #6ca3f8; | ||
| --color-blue: #6ca3f8; | ||
| --color-red: #d35635; | ||
| --color-yellow: #eee170; | ||
| --color-pink: #e8a5a9; | ||
| --color-violet: #5f2ec6; | ||
|
|
There was a problem hiding this comment.
Nice with the root folder for all the color.
Kyparn
reviewed
Mar 2, 2022
Comment on lines
+1
to
+8
| import { createElement } from "../utility/createElem"; | ||
|
|
||
| export default function LoadingStatusComp() { | ||
| const spinnerContainer = createElement("div", "spinner-container"); | ||
| const spinner = createElement("div", "spinner"); | ||
| spinnerContainer.appendChild(spinner); | ||
| return spinnerContainer; | ||
| } |
There was a problem hiding this comment.
Did u have a spinner on the site, did not se one :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deployed website : https://github-clone-2022.netlify.app