Github tracker by Isabell Wästfelt#80
Github tracker by Isabell Wästfelt#80isabellwastfelt wants to merge 11 commits intoTechnigo:mainfrom
Conversation
| .then((data) => { | ||
| console.log(data); | ||
| profileInfo.innerHTML += ` | ||
| <img src=${data.avatar_url}' alt='image of isabellwastfelt at GitHub'> |
There was a problem hiding this comment.
Nice way to fetch the image and profile info
| }; | ||
| getProfile(); //invoking | ||
|
|
||
| const getRepos = () => { |
There was a problem hiding this comment.
Impressive job making this part so clean and simple.
| getRepos(); | ||
|
|
||
| // Pull requests for each project | ||
| const getPullRequests = (repos) => { |
There was a problem hiding this comment.
Same with this part, but maybe even more so. I know how tricky this was and you made it look really simple. Super easy to follow. WELL DONE!
| -webkit-box-sizing: border-box; | ||
| -moz-box-sizing: border-box; | ||
| -webkit-font-smoothing: antialiased; | ||
| text-rendering: optimizeLegibility; |
HWallberg
left a comment
HWallberg
left a comment
There was a problem hiding this comment.
Since I know how hard this was, I'm really impressed by your javascript file! You made it look really simple and it was easy to follow the code.
Nice use of grid and the responsive design! Awesome that you manage to spend some time on the css. It looks really well nice.
If there was time you could work a bit more on the grid to maybe make the boxes not stretch over the entire page when using a big screen.
2 participants
No description provided.