Conversation
jessand77
left a comment
jessand77
left a comment
There was a problem hiding this comment.
Good job, Nadia! Very well written and well structured code with good choices of variable names, function names etc and many comments explaining what the functions do and so on. Advanced code that could have been more difficult to understand but you made it easy to follow and to learn new things from it 🙂
| <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/5.12.0-2/css/all.min.css"> | ||
| <link rel="stylesheet" href="./style.css" /> | ||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/Chart.js/3.7.1/chart.min.js"></script> | ||
| <link rel="icon" type="image/x-icon" href="./favicon.ico"> |
| </select> | ||
|
|
||
| <script src="./script.js"></script> | ||
| <!-- All repo cards are injected here by JavaScript --> |
There was a problem hiding this comment.
Good comment that explains what is happening here, makes it easier to follow.
| <div class="repos-chart"> | ||
| <!-- Technigo projects chart is injected here by JavaScript --> | ||
| <canvas id="reposChart"></canvas> | ||
| </div> |
There was a problem hiding this comment.
I think it was a good choice to place the chart up here in the header. It gives the page layout a good balance.
| :root { | ||
| --white: #ffffff; | ||
| --lightbackground: #f9f7f7; | ||
| --lightblue: #dbe2ef; | ||
| --mediumblue: #3f72af; | ||
| --darkblue: #112d4e; | ||
| } |
There was a problem hiding this comment.
The use of var()-colors makes the code easier to understand (and it's easier to change the colors if you would want to). Good!
| // Function for the tab buttons in repo card | ||
| const openTab = (event, tabName) => { | ||
| let i | ||
| let repoContent = event.currentTarget.parentNode.parentNode.getElementsByClassName("repo-content") // targets the content on each individual repo card |
There was a problem hiding this comment.
I don't think I understand all of this line right now but I really like the result 👍
| // Function to create the profile part of the header with user name and picture | ||
| // -------------------------------------------------- FETCH 1 -------------------------------------------------- |
There was a problem hiding this comment.
Very good use of comments here as well 😀
2 participants
No description provided.