Conversation
There was a problem hiding this comment.
Hi Ida,
I really liked you GitHub Tracker. Everything works and looks great! You should make sure to celebrate this accomplishment!
All I had to comment about was to remove the console.logs on row 23, 40, 44 and 92 as I wrote in my comment. I also forgot to remove them for this week but I got a comment about it from Technigo the week before - that we should remove them so the code looks cleaner.
Keep up the good work! You're awesome!
Joanna
| fetch (API_GIT_USER, options) | ||
| .then(res => res.json()) | ||
| .then(user => { | ||
| console.log(user) |
There was a problem hiding this comment.
I just got this feedback myself: To make the code cleaner, try to remove the console logs before finishing the projects.
I heard Technigo will be much harder with having us remove the console logs when we hand in our projects from now on.
| .then(data => { | ||
| console.log(data) | ||
|
|
||
| //filter out and only show the forked ones, filter out Technigo projects |
There was a problem hiding this comment.
Good with this comment here! Makes it easier to understand the function. Also, good job with the function - looks really clean and efficient!
| } | ||
| else { | ||
| document.getElementById(`commit-${repo.name}`).innerHTML = | ||
| 'Commits Done: (Pull request unavailable)' |
There was a problem hiding this comment.
Nice solution for this text string. Like that you wrote "Pull request unavailable".
2 participants
GitHub Tracker
Create a tracker for my progress as a student at Technigo bootcamp.
The problem
I started with getting the fetches, trying to remember everything from last weeks project. Hade some trouble with (a lot) but "small things" like remembering to pass along the filtered repos and calling functions. This project was intense but I pulled through (pun intended). With more time I would tried harder to get the token to work. And as always more time on styling.
View it live
https://id4h4lling.netlify.app/