Conversation
emmahogberg88
left a comment
emmahogberg88
left a comment
There was a problem hiding this comment.
Well done Anki! I think you have a good structure in your JavaScript. It´s easy to follow your code and your website looks great!
My comments are mostly about indentations, it makes it even more readable to use it in a more "structured way" :) . A suggestion is to use comments in the CSS to make it more easy to navigate through the code.
Good job! ✋
/Emma
| Authorization: `token ${API_TOKEN}`, | ||
| } | ||
| } | ||
| console.log(API_TOKEN) |
| <div class="profile-image"> | ||
| <a href="${USER_URL}"> | ||
| <img src="${data.avatar_url}" alt="Avatar of ${data.login}"> | ||
| </a> | ||
| </div> | ||
| <p class="username">${data.login}<p> | ||
| </div> | ||
| <div> | ||
| <p class="public-repositories">Public repositories: ${data.public_repos}</p> | ||
| </div> |
There was a problem hiding this comment.
Look through the indentations here so the opening and closing-tag are at the same indentation. Also, indent the "childs".
| <p>Branch: ${repo.default_branch}</p> | ||
| <p id="commit_${repo.name}">Commits: </p> | ||
| <p>${repo.language}</p> | ||
| </div> |
| document.getElementById(`commit_${repo.name}`) | ||
| .innerHTML = 'No pullrequest available'; | ||
| } | ||
| }) |
| ` | ||
| }) | ||
| myChart(technigoRepos) | ||
| fetchPullRequests(technigoRepos) |
| }) | ||
| } | ||
|
|
||
| const fetchCommits = (commitsUrl, repoName) => { |
There was a problem hiding this comment.
This part you can remove indentations :)
| text-align: center; | ||
| } | ||
|
|
||
| #hamburger-icon { |
There was a problem hiding this comment.
I think it´s better practice to use classes for styling and save the ids for JavaScript, due to specificity :)
2 participants
No description provided.