Open
Conversation
faypi
reviewed
Mar 6, 2022
Comment on lines
+24
to
+25
| <h4> ${data.bio} </h4> <br> | ||
| <h4> Follow <a href="${data.html_url}"> <i class="fa fa-github" aria-hidden="true"></i> </a> </h4> |
faypi
reviewed
Mar 6, 2022
| .then((userData) => { | ||
| console.log("userData", userData); | ||
| const filteredRepos = userData.filter( | ||
| (item) => item.fork == true && item.name.includes("project-") // to filter technigo projects |
There was a problem hiding this comment.
item.name.includes might be true if a project includes this string in its name. A better fit here might be item.name.startsWith
faypi
reviewed
Mar 6, 2022
| repos.forEach((repo) => { | ||
| console.log("repo", repo); | ||
| fetch( | ||
| `https://api.github.com/repos/Technigo/${repo.name}/pulls?per_page=100`, |
faypi
reviewed
Mar 6, 2022
| .then((res) => res.json()) | ||
| .then((data) => { | ||
| console.log("data", data); | ||
| const myPullRequest = data.find( |
There was a problem hiding this comment.
Nice using the find method here!!! I used filter and I had to do some extra work with arrays 💯
faypi
reviewed
Mar 6, 2022
Comment on lines
+69
to
+73
| if (myPullRequest) { | ||
| fetchCommits(myPullRequest.commits_url, repo.name); | ||
| } else { | ||
| document.getElementById(`commit-${repo.name}`).innerHTML = | ||
| "<b>Commits Done: </b> 0 (Pull request unavailable/Group project) "; |
faypi
reviewed
Mar 6, 2022
faypi
left a comment
faypi
left a comment
There was a problem hiding this comment.
Great code overall! Easy to read and understand the logic. Good job Sherin!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.