Open
Conversation
isabellwastfelt
left a comment
isabellwastfelt
left a comment
There was a problem hiding this comment.
Really nice GitHub tracker!
You added some cool feturs that I really liked. Like the search field.
Your code is easy to read and I understad each part of it.
Check out my tip about where to but the scret.js file in html.
Overall really good job! ⭐
| </div> | ||
|
|
||
| <script src="./chart.js"></script> | ||
| <script src="./secret.js"></script> |
There was a problem hiding this comment.
I got a tip to put secret.js above chart.js and script.js so it loads before and therefore get the information faster.
|
|
||
| const numberCommit = data.length | ||
|
|
||
| //added function so the DOM do not self close tags |
There was a problem hiding this comment.
Nice that you mange to add so much information from github
| <header class="header"> | ||
| <h1 class="header-text">GitHub Tracker</h1> | ||
| <div class="search-container"> | ||
| <form id="search-form"> |
There was a problem hiding this comment.
Really nice with the search function!
| animation-delay: -0.5s; | ||
| } | ||
|
|
||
| @keyframes lds-ripple { |
|
|
||
|
|
||
| /*Loading icon*/ | ||
| .lds-ripple { |
| /* desktop */ | ||
| @media (min-width: 992px) { | ||
|
|
||
|
|
There was a problem hiding this comment.
I would add some size to the chart here because it is kinda big in desktop size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.