Katie Wu#6
Conversation
silvertejp89
left a comment
silvertejp89
left a comment
There was a problem hiding this comment.
The project meets all requirements and functions well! The responsiveness works smoothly. Regarding your code I found it interesting to see your solutions, especially the getModal part. Your commenting is amazing so it helped me a lot during the reading. Thank you for sharing!
/Kriss
| transition: 0.3s ease-in-out; | ||
| } | ||
|
|
||
| .profile-image:hover { |
There was a problem hiding this comment.
The hover effect looks nice! But it also makes me expect that it should link to something...
There was a problem hiding this comment.
Yeah, you are right, not so user friendly. I just wanted to try out different effect 😄
| class="background-image" | ||
| /> | ||
| <h1 class="header-title"> | ||
| <img class="octacat" src="./assets/Octocat.png" alt="octocat" /> GitHub |
There was a problem hiding this comment.
Yeah didn't know that the cat was an octopus too 🐙 until I searched for the icon 😊
| Team Foxes 🦊 | | ||
| <a href="https://www.technigo.io/" target="blank">Technigo</a> | ||
| </p> | ||
| </footer> |
There was a problem hiding this comment.
Pretty footer. I like the link to Technigo, Spread the word sister!
There was a problem hiding this comment.
Yeah, I do commercial for free hehe 😆
| }; | ||
|
|
||
| // function to get a modal(popup) | ||
| const getModal = (projectName) => { |
There was a problem hiding this comment.
Really cool with the extra level, that you can klick on the buttons for more info. Smart to use the loading GIF.
(the pop-up window appears on different hights on my screen though, so I have to scroll down a bit to read.)
There was a problem hiding this comment.
Yeah, I enabled the scrolling, otherwise we can't see the whole window. Maybe I can make the window smaller 🤔
| // for each project, create a button element and class project-card | ||
| // inside each card display the project name and a emoji | ||
| // with append we push each project card | ||
| // and add an eventListener so we can click on each card and get a modal(popup) |
There was a problem hiding this comment.
Could it be an idea to also have a direct link to github-repo in the first page? So the user can either "read more"
on the pop-up window, or go "straight to github-repo".
There was a problem hiding this comment.
It's possible. But have to do another container for that I think 🤔 Because I made the whole project-card clickable to get the pop up window
|
Thank you for your code review Kriss! I appreciate it a lot! |
3 participants
Netlify link: https://katiewu1-githubtracker.netlify.app/
I'm most proud of that I managed to fetch the data that I needed.
I struggled with fetching the Pull Requests, but managed to solve it somehow (before Wednesday live session where we got another solution to solve that problem).
And I tried to change some styling with the charts that I have, but did not quite understand how. So did not change so much.