Naushin Malik-Project github Tracker#55
Conversation
MT-dotse
left a comment
MT-dotse
left a comment
There was a problem hiding this comment.
Great job Naushin,
The website works nicely and even though I haven’t myself made a search function or fetched commit comments it is easy to follow your javascript code. I am very impressed by your search function, well done!
The site is responsive and works on various displays..
You have met the blue, most in the red and the black requirement.
Overall, a great job on the project and I look forward to working together and learn some more javascript from you! :)
| .then(data => { | ||
| console.log(data); | ||
| const userPullReq = data.find((pull) => | ||
| (repo.owner.login === pull.user.login || pull.title.includes('Naushin')) |
There was a problem hiding this comment.
That is clever to use the include method to fetch your pullrequest!
|
|
||
|
|
||
|
|
||
| function getCommits (commitUrl, repoName) { |
There was a problem hiding this comment.
Even if I haven't fetched commits for my own project, I find you code clean and easy to follow. Good job!
| .then(res => res.json()) | ||
| .then(data => { | ||
| if (data.length!== 0){ | ||
| console.log('review', data); |
There was a problem hiding this comment.
It is great that you have used a lot of console.logs, but remember to remove them when it is time for launch.
| font-size: 14px; | ||
| line-height: 24px; | ||
| vertical-align: middle; | ||
| border: 1px solid var(--secondary-color ); |
There was a problem hiding this comment.
That is really clever to structure the colors using primary and secondary.
2 participants
The challenge for this week was the limit of 60 request per hour for github API. Therefore, first, I worked on functionality without any styling, then, I did styling with placeholders and at the end i merged both of them to have the final version.
I have completed most of the requirements. If i had more time, I would have add sorting and more visual representation of data.
Live at: https://naushin-github.netlify.app/