Conversation
Rosanna86
left a comment
Rosanna86
left a comment
There was a problem hiding this comment.
Easy code to read and nice with comments. Think you handled this weeks project very well Jenny. Good job!
Blue Level (Minimum Requirements) [YES]
Red Level (Intermediary Goals) [SOME]
| <main id="projects"></main> | ||
| <header class="header"> | ||
| <nav class="topnav"> | ||
| <h1><i class="fab fa-github"></i> GitHub Tracker</h1> |
There was a problem hiding this comment.
Nice using fontawesome icon in the header
| </div> | ||
| </section> | ||
|
|
||
| <script src="./token.js"></script> |
There was a problem hiding this comment.
Nice with the token. Used one as well, really nice!
| </div> | ||
| <div class="repo-details"> | ||
| <p id="branch">${repo.default_branch}</p> | ||
| <p class="commit" id="commit-${repo.name}"><i class="fas fa-code-branch"></i> </p> |
There was a problem hiding this comment.
Nice with icon from fontawesome again
| }) | ||
| } | ||
|
|
||
| // function to fetch all the languages used in the repository |
There was a problem hiding this comment.
This you solved really nice. The only thing I might have wished was that it could be printed out under each coloured bar what language is what color. Now you need to hover to see.
| .user-information a { | ||
| text-decoration: none; | ||
| color: rgb(42, 78, 98); | ||
| font-weight: bold; |
There was a problem hiding this comment.
Here you have font-weight bold and on line 62 font-weight 400, maybe decide which one to use to be consistent? :)
2 participants
No description provided.