Eddie Lundgren - Github tracker#50
Open
Lundgreneddie wants to merge 6 commits into
Open
Conversation
pdetli
reviewed
Oct 6, 2021
pdetli
left a comment
pdetli
left a comment
There was a problem hiding this comment.
Good job Eddie!
It was easy to follow and understand with the comments and clear structure. 💯
The weather app repo is missing but overall your project met the requirements with some extras.
Comment on lines
+2
to
+3
| "liveServer.settings.port": 5505, | ||
| "git.ignoreLimitWarning": true |
There was a problem hiding this comment.
how smart that you find a way to get rid of the annoying request limit! 💯
Comment on lines
+22
to
+23
| border-radius: 50%; | ||
| border: 2px solid #161616; |
There was a problem hiding this comment.
Maybe it will look more responsive if the image size is changed depending on the device size?
| <a class="username-link" href="https://github.com/Lundgreneddie"> | ||
| <h3 class="username"><i class="fab fa-github"></i> | ||
| ${json.login}</a></h3> | ||
| <p class="repo-amount">This account has a total of ${json.public_repos} repos</p> |
There was a problem hiding this comment.
Good to see extra information about the total repositories. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://lucid-elion-02a2dd.netlify.app/