Conversation
Asivol93
left a comment
Asivol93
left a comment
There was a problem hiding this comment.
Your project looks great with the styling and everyting works as it should! This week was really hard, you should be so proud of yourself! I don't really have any major feedback except good things. You left some descriptive comments in the code (maybe some more for the javascript? Just for others to understand the functions?). You also cleaned it up from console.logs and have good identation so it's easy to follow.
Blue requirements:
- You have a list of all repos forked from Technigo
- You have your username and profile pic
- Latest push for each repo
- Name of your default branch for each repo
- Added the URL to the actual Github repo
- Number of commits for each repo
- It's responsive (mobile first)
- You have visualisation with your chart!
| data: [finishedProjects, allProjects - finishedProjects], | ||
| backgroundColor: ["rgb(204, 194, 193)", "rgb(140, 100, 114)"], |
There was a problem hiding this comment.
Nice that you instead are naming it allProjects - finishedProjects instead of amount. Makes more sense!
| <div class="icon-container"> | ||
| <a href="${data.blog}" target="blank"><img class="linkedin-icon" src="./assets/icon.png"></a> |
There was a problem hiding this comment.
Love that you added a linked in icon with and achor tag! Great idea and it matches your styling!
code/script.js
Outdated
| ); | ||
|
|
||
| // sort function (shows latest to oldest repo) | ||
| forkedRepos.sort(function (oldestRepo, newestRepo) { |
There was a problem hiding this comment.
Clear with a comment and that you named the arguments as oldestRepo and newestRepo. I just went for a & b but this describes it much better. Well done!
| .chart { | ||
| max-width: 300px; | ||
| max-height: 300px; | ||
| display: initial !important; |
2 participants
This week's project was to build a GitHub Tracker where I keep track of all GitHub repos that I've used at Technigo. The tracker updates continuously via information from the GitHub API's, so that the projects for upcoming weeks are added to the tracker.
The project was mostly built with JavaScript and fetched data from API's, but also styled with CSS so that it has a responsive design.
I worked a lot with my project team and figured out the logic to find the right data from the API's, and how to display it in the right way. I practiced fetching and filtering data, creating a chart function and sorting function, and how to use dynamic id's to display information in the right place.
I created all the JavaScript functions first and then moved on to styling the website.
I thought the project was really hard at times, and now I am really satisfied with the result. If I had more time I would like to add a search function so that the tracker can display information from different GitHub accounts.
https://mj-github-tracker.netlify.app/