Gustav Frid#45
Closed
gustavfrid wants to merge 51 commits into
Closed
Conversation
ghost
reviewed
Oct 6, 2021
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Hello!
Thank your for letting me take a look at your code. Your code always impresses me but it is a tad hard for me to understand some of the functions youve implemented. But i feel like that was a great exersize for me aswell. You are meeting all requirments what i can see and i really like the look of your site!
| // data: lineData, | ||
| // }; | ||
|
|
||
| // let lineChart = (ctx) => new Chart(ctx, lineConfig); |
| <h1>GitHub Tracker</h1> | ||
| <h2>Projects:</h2> | ||
| <main id="projects"></main> | ||
| <head> |
| color: blue; | ||
| } */ | ||
|
|
||
| @media (min-width: 768px) { |
| align-items: center; | ||
| } | ||
|
|
||
| /* unvisited link */ |
There was a problem hiding this comment.
thank you for these comments. your code is very complex for me so the comments help me understand it better!
| }); | ||
| }; | ||
|
|
||
| sortSizeBtn.addEventListener('click', () => sortRepos(reposArr, 'size', false)); |
There was a problem hiding this comment.
feels like you implemented alot of what we learned when we made the guess who game. great to see that you reuse the knowledge and do so with ease
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://gustav-week7-github-tracker.netlify.app/