Project 7 - Rebecca Philipson#41
Conversation
There was a problem hiding this comment.
Very nice project Rebecca! This was a hard task and we had to do apply so many new concepts about catching data from the API. Congrats!
Your code is clear and easy to follow. You have a good use of comments and structuring your code.
Well done! 👍 👏
[YES ] Am I able to understand the code easily?
[NO ] Does the code have lots of duplicates? Could it be tidied up?
[ works ] Does it work or does anything look broken?
[Yes] Does it follow the general and blue requirements?
| src="https://cdn-icons-png.flaticon.com/512/2111/2111612.png" | ||
| alt="githublogo" | ||
| /> | ||
| <h2>Projects:</h2> |
There was a problem hiding this comment.
Maybe you can try to use a fontawesome-icon instead of an image in one of your next projects. You can find pretty much all standard icons there in high resolution https://fontawesome.com/v5.15/icons/github
There was a problem hiding this comment.
Thank you Birgit! I will definitely have a look. :)
| .projectinfo:nth-child(6) { | ||
| margin-bottom: 40px; | ||
| } | ||
|
|
There was a problem hiding this comment.
Interesting this method with nth-child. Never seen it before. Does it update to a higher number, if you have more projects than 6 on your page?
.projectinfo:nth-child(6)
| .projectinfo:nth-last-child(-n + 2) { | ||
| margin-bottom: 60px; | ||
| } | ||
|
|
There was a problem hiding this comment.
this looks like a setting that would adjust dynamically according to how many projects there are. Maybe use a construct like that on row 89?
.projectinfo:nth-last-child(-n + 2)
There was a problem hiding this comment.
Yeah, you're totally right. Thanks for pointing that out.
| .heroimage { | ||
| background: linear-gradient(rgba(44, 40, 27, 0.39), rgba(41, 37, 25, 0.76)), | ||
| url("https://images.unsplash.com/photo-1607970669494-309137683be5?ixid=MnwxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHx8&ixlib=rb-1.2.1&auto=format&fit=crop&w=1470&q=80"); | ||
| height: 65vh; |
There was a problem hiding this comment.
Nice to use a linear gradient on top of the pic!
|
Great feedback Birgit! Thanks a lot. |
2 participants
No description provided.