Week 7 - Project-github-tracker -Jessi Nygren Walhed#40
Week 7 - Project-github-tracker -Jessi Nygren Walhed#40hemmahosjessi wants to merge 23 commits intoTechnigo:mainfrom
Conversation
Ajliin
left a comment
Ajliin
left a comment
There was a problem hiding this comment.
Such a brilliant job! The site looks overall very professional you have such a good eye for design and layout! The responsiveness works perfect and the code is clean and structured. You have met all requirements!
I really tried to find some things on to improve, but it was a hard job! I have made some small comments in code. I have learnt a lot reading you code, big thank you! (Css 471 rows :o)
A nice thing to add would be a specific name on the netlify-site (easy to change in netlify under site-settings —> change site name) And maybe a logo in the tab :)
| .main { | ||
| display: flex; | ||
| flex-direction: row; | ||
| padding-left: 5%; |
There was a problem hiding this comment.
padding: 0 5%; would be the same (save one row code :)
| .then(response => (response.json())) | ||
| .then(data => { | ||
| const forkedRepos = data.filter(repo => repo.fork && repo.name.startsWith('project-')) | ||
| console.log('My forked repos', forkedRepos) |
There was a problem hiding this comment.
console.log - love them, but they got to go
| console.log('My forked repos', forkedRepos) | ||
|
|
||
| forkedRepos.forEach(repo => projectsContainer.innerHTML += ` | ||
| <div class="project-card"> |
There was a problem hiding this comment.
Nice to see all the styling in the innerHTML, good job!
| .then(data => { | ||
| const myPullRequests = data.find( | ||
| (pull) => pull.user.login === repo.owner.login) | ||
| console.log('My Pull requests', myPullRequests) |
| fetch(myCommitsUrl) | ||
| .then(response => (response.json())) | ||
| .then(data => { | ||
| console.log('My commits', data) |
|
|
||
| getRepos() | ||
|
|
||
|
|
There was a problem hiding this comment.
You use very little comments for the js-code, it might help when u going back to this project later on if you have written some more comments on what u have done.. Just an idea
| transform-origin: bottom left; | ||
| } | ||
|
|
||
| a::before { |
| @media (min-width: 768px) and (max-width: 991px) { | ||
|
|
||
| .main { | ||
| display: flex; |
| } | ||
|
|
||
| .left-area { | ||
| box-sizing: border-box; |
There was a problem hiding this comment.
this should be uneccesary if u have it in html?
2 participants
No description provided.