Conversation
…s. Began with CSS.
| background-color: #7aa094; | ||
| display: grid; | ||
| grid-column: span 12; | ||
| border-radius: 25px 0px; |
There was a problem hiding this comment.
A small detail that makes the boxes look really good in the mobile version I think :)
| animation-delay: -0.5s; | ||
| } | ||
|
|
||
| @keyframes lds-ripple { |
| </header> | ||
|
|
||
| <div id="myProfile" class="my-profile"></div> | ||
| <div id="loading" class="lds-ripple"><div></div><div></div></div> |
There was a problem hiding this comment.
Cool that you added some "loading" content in case the information from the API is not shown
| <header class="header"> | ||
| <h1 class="header-text">GitHub Tracker</h1> | ||
| <div class="search-container"> | ||
| <form id="search-form"> |
| const USER_URL = `https://api.github.com/users/${USER}` | ||
| const projectsContainer = document.getElementById('projects') | ||
| const ldsripple = document.getElementById('loading') | ||
| const Auth = { } |
There was a problem hiding this comment.
Really useful to have a github token :)
| getCommits(myPullRequest[0].commits_url, (data) => { | ||
| const numberOfCommits = data.length | ||
| //added function so the DOM do not self close tags | ||
| let boxHtml = `<div class="box-repo ${repo.name}">`; // https://stackoverflow.com/questions/46300108/innerhtml-closes-tags |
There was a problem hiding this comment.
Great that you add the link to Stack Overflow as a comment
There was a problem hiding this comment.
Hi Rosanna! I really like your page and I can totally relate to the problems you had during the week. It took some time to grasp all the Javascript code and how to connect everything. I like that you add comments through the whole code (makes it clean and readable) and great also that you had the time to add a search field. :)
[YES] Am I able to understand the code easily?
[NO] Does the code have lots of duplicates? Could it be tidied up?
[WORKS] Does it work or does anything look broken?
[YES (and above)] Does it follow the general and blue requirements?
2 participants
This week, we want you to create a place to keep track of the GitHub repos that you're using here at Technigo.
What I learned:
This week it was a lot of JS and API requests. I have learned about fetch, API:S, finding info in an API and filtering. And how to add a gitHub token so you have limitless requests.👩💻
This week I had a problem to understand the connection between the code. I really had to narrow in all down to small small small pieces. BUT after Maks Wednesday live session I got more of a hang of it, the cheese sandwich comparison really made it more clear to me.
My own reflection
This week was really intense and I had a really big problem mentally. But in the end I solved everything and my page turned out alright 🙂