Project_github-tracker by Jessica Falk#35
Open
jessicatf wants to merge 4 commits intoTechnigo:mainfrom
Open
Conversation
Meeteyes
reviewed
Oct 8, 2021
Meeteyes
left a comment
Meeteyes
left a comment
There was a problem hiding this comment.
Hi, Jessica!
Good job on the Github tracker! The code is very economic and most importantly it works. The way you have structured the code was easy to follow and very readable. The css wasn't the focus for this task and you probably have improved your skills during this week. It will get there. Have a nice weekend and enjoy some rest!
Best,
Reinis
|
|
||
| const personalInfo = document.getElementById('personalInfo'); | ||
| const projectsContainer=document.getElementById('projects'); | ||
| const USER='jessicatf'; |
There was a problem hiding this comment.
Nice, that you are using variable for the username!
| ); | ||
|
|
||
|
|
||
| if (myPullRequest) { |
There was a problem hiding this comment.
Great that you included the if statement to check if there has been pulls or commits!
|
|
||
|
|
||
|
|
||
| /*Jennie |
There was a problem hiding this comment.
Commented out code, only for drafts. The final version should be clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Project_github-tracker by Jessica Falk