Github tracker by Efthymios Karakasis#34
Conversation
elsisco
left a comment
elsisco
left a comment
There was a problem hiding this comment.
You fulfill all the blue requirements for this week project and the fetches are working properly - well done! One small thing I noticed is the the GitHub logo gets distorted on bigger screen sizes (see comment in code) and that the background color in the PNG is not matching the background color of the page. To replace the logo file with a PNG or an SVG with transparent background would do the trick. Good job!
| }</span></div> | ||
| <h4 class="repo-item3">Last updated: ${new Date( | ||
| repo.updated_at | ||
| ).toLocaleDateString()}</h4> |
There was a problem hiding this comment.
Nice that you chose to display the date with .toLocaleDateString().
| justify-content: flex-end; | ||
| } | ||
| .logo-image { | ||
| width: 100px; |
There was a problem hiding this comment.
I think this is what causes the distorted logotype since the size of the logo container already is set to 50px on line 12.
| <h4 class="repo-item3">Last updated: ${new Date( | ||
| repo.updated_at | ||
| ).toLocaleDateString()}</h4> | ||
| <h5 class="repo-item4">${language}</h5> |
There was a problem hiding this comment.
Great detail to display the project main language as well.
2 participants
No description provided.