Finished blue requirements#27
Open
isomoth wants to merge 6 commits into
Open
Conversation
HedvigM
reviewed
Oct 7, 2021
HedvigM
left a comment
There was a problem hiding this comment.
Hi!
I must start this review off with saying that i have notihing "bad" to say about your code, it is easy to understand, its clean and i enjoy having your comments in the document. It made it easy to follow and i can see and understand where you have hade struggles and se how you are thinking with the comments in place.
Youre project reaches up to the blue requirements and you have also incorporated some extra features, with the sorting function. Really good job!
I also enjoyed your list in the readme file, it was nice written, to the point and it explained where you struggled and explained your thoughts abour the project.
Great work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deployed version: https://github-tracker-gonzalez.netlify.app/
The time constrains from having a lot of overtime at work only allowed for the basic requirements on this project.