Skip to content

Finished blue requirements#27

Open
isomoth wants to merge 6 commits into
Technigo:mainfrom
isomoth:main
Open

Finished blue requirements#27
isomoth wants to merge 6 commits into
Technigo:mainfrom
isomoth:main

Conversation

@isomoth

@isomoth isomoth commented Oct 2, 2021

Copy link
Copy Markdown

Deployed version: https://github-tracker-gonzalez.netlify.app/

The time constrains from having a lot of overtime at work only allowed for the basic requirements on this project.

  • The biggest challenge in terms of fetching was the getCommits function, since the API didn't have a direct path to fetch each commit. The solution was to first fetch all repos, then filter the forked ones. Then get their pull requests, and finally invoke the getCommits function within a conditional (if the project had any pull requests).
  • Dynamic CSS with JavaScript was also a challenge, since the styling mindset was purely based on the HTML document up to this point. I learned to check the dev tools more often, to make sure the dynamic structure of the document was still coherent.
  • The responsiveness of the chart was tricky because of the quirky nature of chart.js. I used a combination of the library's documentation and Stack Overflow answers to get ahead. In the end, I decided to go for a bar graphic instead of a donut. Its rectangular forms matched my layout better.

@HedvigM HedvigM left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!
I must start this review off with saying that i have notihing "bad" to say about your code, it is easy to understand, its clean and i enjoy having your comments in the document. It made it easy to follow and i can see and understand where you have hade struggles and se how you are thinking with the comments in place.

Youre project reaches up to the blue requirements and you have also incorporated some extra features, with the sorting function. Really good job!

I also enjoyed your list in the readme file, it was nice written, to the point and it explained where you struggled and explained your thoughts abour the project.

Great work!

Comment thread code/script.js
Comment thread code/script.js
Comment thread code/script.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants