Open
Conversation
MariaThomasson
left a comment
MariaThomasson
left a comment
There was a problem hiding this comment.
You have done a nice work with all blue level requirements done. It follows the code guidelines and my only suggestion is to add comments in the CSS and HTML as nice and clear as you did in JavaScript. Not really necessary this week but when we do project with lots of code it´s so good with this comments when you do the review. Good work!!
|
|
||
| Every project should be deployed somewhere. Be sure to include the link to the deployed project so that the viewer can click around and see what it's all about. | ||
| # View it live | ||
| https://kaliine-github-tracker.netlify.app/ |
There was a problem hiding this comment.
Nice and clear description of your journey this week and I agree that the lectures this week helped a lot :)
| /* To do: | ||
| - review_comments_url | ||
| - A chart */ | ||
|
|
There was a problem hiding this comment.
Nice work with all the fetch, .then, forEach etc and I really liked all your comments witch makes it easy to follow in your code and what it´s meant to do/get. The Aip´s work fine as far as I can tell. Well done, this was a tricky week.
| } | ||
|
|
||
| } | ||
|
|
There was a problem hiding this comment.
Very straight forward and easy to read code so no remarks on the CSS. It´s responsive and looks good in all formats. Well done!
| <img class="github-icon" src="./github-logo.png" alt="github icon"/> | ||
| <h1 class="main-title">GitHub Tracker</h1> | ||
| </header> | ||
|
|
There was a problem hiding this comment.
I like your take on the style as a GitHub-page. One suggestion is that it would be nice with a link to your GitHub-profile.
Author
|
Thank you Maria! Great comments that I will look into. //Karoline
________________________________
Från: Maria Thomasson ***@***.***>
Skickat: den 5 oktober 2021 14:56
Till: Technigo/project-github-tracker ***@***.***>
Kopia: Karoline Mann ***@***.***>; Author ***@***.***>
Ämne: Re: [Technigo/project-github-tracker] Github Tracker by Karoline Mann (#26)
@MariaThomasson commented on this pull request.
You have done a nice work with all blue level requirements done. It follows the code guidelines and my only suggestion is to add comments in the CSS and HTML as nice and clear as you did in JavaScript. Not really necessary this week but when we do project with lots of code it´s so good with this comments when you do the review. Good work!!
________________________________
In README.md<#26 (comment)>:
-Start by briefly describing the assignment in a sentence or two. Keep it short and to the point.
-
-## The problem
-
-Describe how you approached to problem, and what tools and techniques you used to solve it. How did you plan? What technologies did you use? If you had more time, what would be next?
-
-## View it live
-
-Every project should be deployed somewhere. Be sure to include the link to the deployed project so that the viewer can click around and see what it's all about.
+# View it live
+https://kaliine-github-tracker.netlify.app/
Nice and clear description of your journey this week and I agree that the lectures this week helped a lot :)
________________________________
In code/script.js<#26 (comment)>:
+ })
+}
+
+
+
+
+
+//Call the getRepos function
+getRepos()
+
+
+
+ /* To do:
+ - review_comments_url
+ - A chart */
+
Nice work with all the fetch, .then, forEach etc and I really liked all your comments witch makes it easy to follow in your code and what it´s meant to do/get. The Aip´s work fine as far as I can tell. Well done, this was a tricky week.
________________________________
In code/style.css<#26 (comment)>:
+ }
+
+ .main-section {
+ display: grid;
+ grid-template-columns: 0.8fr 1.7fr;
+ grid-gap: 8px;
+ }
+
+ .chart-section {
+ width: 300px;
+ max-width: 300px;
+ margin: 50px auto 100px auto;
+ }
+
+}
+
Very straight forward and easy to read code so no remarks on the CSS. It´s responsive and looks good in all formats. Well done!
________________________________
In code/index.html<#26 (comment)>:
</head>
<body>
- <h1>GitHub Tracker</h1>
- <h2>Projects:</h2>
- <main id="projects"></main>
+ <header class="header">
+ <img class="github-icon" src="./github-logo.png" alt="github icon"/>
+ <h1 class="main-title">GitHub Tracker</h1>
+ </header>
I like your take on the style as a GitHub-page. One suggestion is that it would be nice with a link to your GitHub-profile.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#26 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ATIZU2QSCWQFPWDUPPA7WWTUFLYZLANCNFSM5FGYPQJQ>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
[https://ipmcdn.avast.com/images/icons/icon-envelope-tick-round-orange-animated-no-repeat-v1.gif]<https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail> Virus-free. www.avast.com<https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail>
|
![https://ipmcdn.avast.com/images/icons/icon-envelope-tick-round-orange-animated-no-repeat-v1.gif]<https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail](https://ipmcdn.avast.com/images/icons/icon-envelope-tick-round-orange-animated-no-repeat-v1.gif]<https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail){kind=link}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.