project-github-tracker-PriscilaAlfaro#24
Open
PriscilaAlfaro wants to merge 5 commits into
Open
Conversation
HelenaW86
reviewed
Oct 17, 2021
HelenaW86
left a comment
HelenaW86
left a comment
There was a problem hiding this comment.
So nice to read your code Priscila! nice structure and really inspiering!!
| } else { | ||
| throw new Error('Request failed!') | ||
| } | ||
| } catch (error) { |
| <div class="general-info project-title"> | ||
| <h2 class="project-name"><a href=${repo.html_url} target="_blank"><i class="fas fa-project-diagram"></i> ${repo.name.toUpperCase()}<a></h2> | ||
| <h3 id="default-branch"> Default branch: ${repo.default_branch}</h3> | ||
| <h3>Main language: ${repo.language ? repo.language : "No information"}</h3> |
There was a problem hiding this comment.
like that you used ? : instead of if-else, so much shorter code :)
| <h3>Pull requests</h3> | ||
| <h4>Total pullrequest: ${repo.allPullRequest.total_count}</h4> | ||
| ${repo.allPullRequest.total_count === 0 ? | ||
| `<h4>This repository don't any have Pull Request</h4>` : |
There was a problem hiding this comment.
God that you used an alt text when there are no pull requests.
| } | ||
|
|
||
|
|
||
| const fetchCommitsFromPullRequest = async (repoName, pullRequestNumber) => { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: https://project-github-tracker.netlify.app/